On 08/28/2015 12:25 PM, Pavel Březina wrote:
I would be also curious why you need to provide hacks
for printing argument description for autohelp.
There is a much more elegant way how to do it with libpopt.
(small hint POPT_ARGFLAG_DOC_HIDDEN in sss_tool_common_opts)
Your curiosity is remarkable, though I have no idea why are you
hinting this
flag.
because I cannot see a reason why we should
write tool tip with fprintf if
there is a way with libpopt.
Because there is a way, but not an straight-forward and elegant way.
Since there is only one option and the list is not likely to be
extended, there is no problem with doing it this way.
It's not a NACK but I do not like your solution
so I will not ACK it either. You need to find someone else.
I'm completely fine with this.
LS
I am doing code review for fixed patch now. Patch looks good to me and
it works.
I discussed the problem above (about fprintf vs. libpopt) with both
offline. The libpopt solution starts here [1] and I agree it would not
be straightforward. So I am inclined to the solution presented in the patch.
Regards
Petr
[1] src/tools/sss_override.c:1412
PS: I am waiting for CI tests.
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
