On 09/14/2015 03:25 PM, Jakub Hrozek wrote:
On Mon, Sep 14, 2015 at 02:15:39PM +0200, Petr Cech wrote:
 From 4246d5cd91c4c34b8524be5bfce38c57163a6e2b Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik<lsleb...@redhat.com>
Date: Fri, 11 Sep 2015 17:04:58 +0200
Subject: [PATCH] squash_me

---
  Makefile.am                        | 2 +-
  src/providers/ipa/ipa_hbac.exports | 8 ++++++--
  2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 
851f943a4c57b70cee4f4f34e83457e7d204aff1..a2a868455f91fac212fcfa7b41681086145c06f9
 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -928,7 +928,7 @@ libipa_hbac_la_LIBADD = \
      $(UNICODE_LIBS)
  libipa_hbac_la_LDFLAGS = \
      -Wl,--version-script,$(srcdir)/src/providers/ipa/ipa_hbac.exports \
-    -version-info 0:1:0
+    -version-info 1:0:1
Lukas, are you sure this version number 1:0:1? If you're really sure this
number, I have not understood it properly.

I have not read the patch at all, just adding a link about version info
[1]
     
https://www.gnu.org/software/libtool/manual/libtool.html#Updating-version-info

The trick to follow this guide is that it's really an algorithm, so you
shouldn't stop at the first change, but continue (potentially reverting
or overwriting previous changes)
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

I understand, how we changed -version-info (it is exactly by steps as described in [1]), but I don't understand clearly changes in .exports.
Petr
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to