On (18/09/14 20:08), Michal Šrubař wrote: >On 09/11/2014 04:14 PM, Jakub Hrozek wrote: >>On Thu, Sep 11, 2014 at 02:47:33PM +0200, Šrubař Michal wrote: >>>Cituji Pavel Březina <[email protected]>: >>> >>>>On 09/08/2014 03:47 PM, Jakub Hrozek wrote: >>>>>On Wed, Aug 20, 2014 at 01:40:45PM +0200, Šrubař Michal wrote: >>>>>>Hi guys, I spent some time working at this ticket >>>>>>https://fedorahosted.org/sssd/ticket/1108 and I think it's finally ready >>>>>>to >>>>>>be reviewed by others. >>>>>> >>>>>>Description of the problem and scope of the changes can be found in the >>>>>>commit message. I also wrote some unit tests but the patch is a quite long >>>>>>already so I think it would be better to send the tests as an another >>>>>>patch. >>>>>>Or should I create a patch for each modified file? >>>>>> >>>>>> >>>>>Thank you very much for taking the time to finish the code after your >>>>>thesis was done! >>>>> >>>>>I'm bound to other tasks at the moment, though, I wonder if Pavel could >>>>>find some time to review the patch? >>>>I'm going to PTO so unfortunately no. However from the first very quick >>>>look I think the concept is OK. It would be nice to have the changes made >>>>in more commits instead of one huge, but well... what can you do now. >>>I can break up the patch into smaller pieces so it can be more easily >>>reviewed. But I am also a bit busy at the moment but I will do it asap. >>No hurry if you're busy and thanks for keeping in touch. But I agree >>with Pavel that several patches would be easier to digest. >I finally found some time to break up the patch and here are first two parts >which prepares the LDAP sudo provider for use with the IPA sudo provider. > Surprisingly, patches still aply on master. But it might change in future. So it would be better to have link to git. https://fedorapeople.org/cgit/lslebodn/public_git/sssd.git/log/?h=native_ipa_sudo
LS _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
