On Wed, Oct 14, 2015 at 12:27:12PM +0200, Jakub Hrozek wrote: > On Wed, Oct 14, 2015 at 11:29:09AM +0200, Pavel Březina wrote: > > On 10/13/2015 03:51 PM, Jakub Hrozek wrote: > > >On Tue, Oct 13, 2015 at 12:08:22PM +0200, Pavel Březina wrote: > > >>>I don't like overriding opt_name and opt_id here, the caller of > > >>>check_cache() does not expect that those values change (especially > > >>>because opt_name is declared const in the header). Additionally I'm not > > >> > > >>The values won't change in the caller of check_cache. > > > > > >But it's still really bad taste to change input parameters, can we have > > >a separate variable we assign to? > > > > Ok, new patches are attached. > >
Thank you Pavel, ACK from me as well. bye, Sumit > > > From e4fe1bbf24b6739c7dce43a25a06b7b891ecc97e Mon Sep 17 00:00:00 2001 > > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrez...@redhat.com> > > Date: Sun, 11 Oct 2015 16:45:19 +0200 > > Subject: [PATCH 1/3] nss: send original name and id with local views if > > possible > > > > Resolves: > > https://fedorahosted.org/sssd/ticket/2833 > > ACK > > the bug is fixed and both byname and byid lookups still work. > > > From 21ad142974edeaaa487d188e27546f69356c9257 Mon Sep 17 00:00:00 2001 > > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrez...@redhat.com> > > Date: Sun, 11 Oct 2015 17:38:34 +0200 > > Subject: [PATCH 2/3] sudo: search with view even if user is found > > ACK > > the code looks good to me and sudo still works > > > From 9d5e53c02eee2ac0d1aebbbcca542f69a0ce9feb Mon Sep 17 00:00:00 2001 > > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrez...@redhat.com> > > Date: Sun, 11 Oct 2015 17:53:28 +0200 > > Subject: [PATCH 3/3] sudo: send original name and id with local views if > > possible > > > > ACK > > the code looks good to me and sudo still works > > I'm just waiting for CI and Coverity before pushing. > _______________________________________________ > sssd-devel mailing list > sssd-devel@lists.fedorahosted.org > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel