On 11/13/2015 06:19 PM, Pavel Reichl wrote:
Thanks Nick, updated patch attached.
Thanks, Pavel, this looks really neat now! I have only two comments.
+def test_simple_user_override(ldap_conn, env_simple_user_override): + """Test entries are overriden""" + +
Shouldn't there be an actual test here?
+# Regression test for bug #2802 +# sss_override segfaults when accidentally adding --help flag to some commands + + +def test_regr_2802_override(request, ldap_conn): + prepare_sssd(request, ldap_conn)
I had no idea this could actually work, I mean getting "request" in a test. Can you give a link to documentation where this is explained? Otherwise, could you please move the setup to a proper fixture? Tests are not supposed to have setup/teardown inside, AFAIK, unless this is really official.
+ + subprocess.check_call(["sss_override", "user-del", "--help"])
Nick _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
