On Wed, Nov 11, 2015 at 06:05:02PM +0100, Michal Židek wrote: > On 11/11/2015 06:03 PM, Michal Židek wrote: > >On 11/09/2015 09:19 AM, Lukas Slebodnik wrote: > >>On (08/11/15 23:49), Michal Židek wrote: > >>>I am attaching patch that can be applied and squashed into > >>>Nick's patch. I am sending both patches to see what > >>>changes have been made, *please squash them before pushing*. > >>> > >>>This patch just removes the negchace (together with the > >>>asserts that are testing it) and memcache, > >>>and adds global constant to avoid using magic values. > >>> > >>Patches for bug with memory cache are already on the list. > >>So it would be good to remove workarounds. > >>Could you prepare new patches on top of mc patches? > >> > >>LS > >>_______________________________________________ > >>sssd-devel mailing list > >>sssd-devel@lists.fedorahosted.org > >>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel > >> > > > >I modified the "squashing" patch to remove the > >workaround for failing memcache. > > > >SQUASH THESE 2 ATTACHED PATCHES BEFORE PUSHING > >and use the commit message from Nick's > >(first) patch (I altered the message a little > >so that the removed test are not mentioned). > > > >CI link passed: > >http://sssd-ci.duckdns.org/logs/job/32/83/summary.html > > > >Michal > > > > I forgot to say that the memcache fix must be > pushed before this. > > Michal
CI passed some time ago: http://sssd-ci.idm.lab.eng.brq.redhat.com:8080/job/ci/3304/ and we agreed off-list that the fixup is a good thing to do. I'm going to push the patches.. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel