On 12/11/2015 03:13 PM, Lukas Slebodnik wrote:
On (11/12/15 12:59), Petr Cech wrote:
On 12/11/2015 12:46 PM, Jakub Hrozek wrote:
On Fri, Dec 11, 2015 at 12:19:27PM +0100, Petr Cech wrote:
From 897fd7a64770955a58c2dc7f71acdbf086477e8f Mon Sep 17 00:00:00 2001
From: Petr Cech <pc...@redhat.com>
Date: Wed, 9 Dec 2015 08:13:59 -0500
Subject: [PATCH] KRB5_CHILD: Debug logs for PAC timeout
This patch adds debug message that inform user when KRB5_CHILD calls
PAC responder. This action might take a bit of time in case the cache
is not populated or up to date.
Resolves:
https://fedorahosted.org/sssd/ticket/2846
---
src/providers/krb5/krb5_child.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c
index
b39269ee8028e5992b22860bb8a97b4ff824d087..acee7a986d84e738fa2a95bef12477b1f1c9b953
100644
--- a/src/providers/krb5/krb5_child.c
+++ b/src/providers/krb5/krb5_child.c
@@ -193,6 +193,9 @@ static errno_t sss_send_pac(krb5_authdata **pac_authdata)
ret, errnop);
return EIO;
}
+ DEBUG(SSSDBG_TRACE_FUNC, "PAC responder contacted. It might take a " \
+ "bit of time in case the cache is not " \
^^
it's not required do escape new
line. Preprocessor can
concatenate string even without
it.
+ "up to date.\n");
Usually, we start long debug message on next line.
e.g.
DEBUG(SSSDBG_TRACE_FUNC,
"PAC responder contacted. It might take a "
...
LS
Hi Lukas,
I addressed your comments, see attachment.
And I did a little investigation---if we use clang-format the ' \' on
the end of lines are really vanished. It is good news to everyone I hope.
I am afraid that it will be nearly impossible to say that we have more
than one coding style for DEBUG().
Regards
Petr
>From 8611f57b36ac498ad29dbb902c4cdd1238bff249 Mon Sep 17 00:00:00 2001
From: Petr Cech <pc...@redhat.com>
Date: Wed, 9 Dec 2015 08:13:59 -0500
Subject: [PATCH] KRB5_CHILD: Debug logs for PAC timeout
This patch adds debug message that inform user when KRB5_CHILD calls
PAC responder. This action might take a bit of time in case the cache
is not populated or up to date.
Resolves:
https://fedorahosted.org/sssd/ticket/2846
---
src/providers/krb5/krb5_child.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c
index b39269ee8028e5992b22860bb8a97b4ff824d087..c8b8a00533c3d4f1ea9fa4c90122708cf61a1820 100644
--- a/src/providers/krb5/krb5_child.c
+++ b/src/providers/krb5/krb5_child.c
@@ -193,6 +193,9 @@ static errno_t sss_send_pac(krb5_authdata **pac_authdata)
ret, errnop);
return EIO;
}
+ DEBUG(SSSDBG_TRACE_FUNC,
+ "PAC responder contacted. It might take a bit of time in case the "
+ "cache is not up to date.\n");
return EOK;
}
--
2.4.3
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
