On 01/28/2016 12:28 PM, Jakub Hrozek wrote:
On Mon, Jan 25, 2016 at 08:54:53PM +0100, Jakub Hrozek wrote:
On Mon, Jan 25, 2016 at 05:16:37PM +0100, Pavel Reichl wrote:
Hello,
attached patch does not seem to suffer from these errors any more.
Shall I ask user who reported the bug If he is willing to test this new version
of the patch? IIRC he needs more then a week for a testing to be conclusive...
Thanks.
Yes, please. We can do the review in the meantime.
The new code looks good to me and there is definitely improvement in
memory consumption. Before the patch, after requesting 100000 netgroups
the memory usage went from ~30 to ~250MBs. After the patch, the memory
went from ~30 to ~50 MBs.
Did you take a look in your testing what is the extra 20MBs or should I?
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
How exactly did you measure the memory use? In my testing I used talloc_full_report (the patch was attached in 1st version of patch). I rerun query for 100000 netgroups, right after the test talloc reported 'full talloc report on 'null_context'
(total 1738774 bytes in 48682 blocks)', a few minutes after the test finished I got: 'full talloc report on 'null_context' (total 16258 bytes in 417 blocks)'.
I'm not seeing any such leaks as you observed.
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
