On Tue, Feb 09, 2016 at 08:20:38AM +0100, Lukas Slebodnik wrote: > On (09/02/16 08:15), Jakub Hrozek wrote: > >On Tue, Feb 09, 2016 at 08:09:33AM +0100, Lukas Slebodnik wrote: > >> On (08/02/16 13:56), Pavel Reichl wrote: > >> >On 02/08/2016 10:48 AM, Jakub Hrozek wrote: > >> >>On Mon, Feb 08, 2016 at 10:34:16AM +0100, Pavel Reichl wrote: > >> >>> > >> >>> > >> >>>On 02/05/2016 03:16 PM, Lukas Slebodnik wrote: > >> >>>>> > >> >>>>The ticket is about "SSSD should be about to display message to the > >> >>>>user when > >> >>>>the account in Active Directory is 'locked out'" > >> >>>> > >> >>>>If the string is not standardized among AD versions > >> >>>>than this ticket is NOT solved. > >> >>> > >> >>>So what do you propose? Rename ticket to contain version of tested AD? > >> >>>Or should we say user that although we have fix that would work for him > >> >>>it might not work for all AD versions so we won't provide it? > >> >> > >> >>It would be nice to mention what we tested with in the commit message. > >> > > >> >OK, done. > >> > > >> >> > >> >>> > >> >>>Can we ask our QA to test on all AD version they can lay their hands on? > >> >> > >> >>Yes, I think we can test 2012 and 2008. Probably not worth testing 2003 > >> >>anymore. > >> >> > >> > > >> >I updated the relevant BZ. > >> > >> >From 5a4ca73e16e4eec023108387cd8c572c34496e9b Mon Sep 17 00:00:00 2001 > >> >From: Pavel Reichl <prei...@redhat.com> > >> >Date: Fri, 5 Feb 2016 07:27:38 -0500 > >> >Subject: [PATCH 1/2] SDAP: Add return code ERR_ACCOUNT_LOCKED > >> > > >> >Add code to distinquish state when account is locked in Active > >> >Directory server. > >> > > >> >Tested against Windows Server 2012 > >> > > >> Thank you very much for testing. I really appreciate it. > >> It would be enought to test with one kind of AD if we planned > >> to push the patch only to master branch. > >> > >> However there is a plan to push it also to stable branch. > >> It would be good to test with more versions. > >> We kind of suport few version of AD. > >> /* Values from > >> * http://msdn.microsoft.com/en-us/library/cc223272%28v=prot.13%29.aspx > >> */ > >> enum dc_functional_level { > >> DS_BEHAVIOR_WIN2000 = 0, > >> DS_BEHAVIOR_WIN2003 = 2, > >> DS_BEHAVIOR_WIN2008 = 3, > >> DS_BEHAVIOR_WIN2008R2 = 4, > >> DS_BEHAVIOR_WIN2012 = 5, > >> DS_BEHAVIOR_WIN2012R2 = 6 > >> }; > >> > >> If we are not bale to find the behaviour in the MSDN documentation > >> then we should do upstream first testing and do not rely on later testing > >> of patches in stable branch. > > > >I don't think we should put any effort into testing server versions that > >are not supported by Microsoft anymore. That would be like testing IPA > >features with IPA 2.x.. > I didn't ask to test all version. I asked to test *MORE* versions. > e.g. >= 2008
Yes, we should test those. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
