This is just a code-style patch, but I got confused by the two if
statements, they made me think they were unrelated..
>From 20259fe42b8cec38b913c17a6b5be2e6456a31d3 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <[email protected]>
Date: Mon, 22 Feb 2016 10:56:52 +0100
Subject: [PATCH] IPA: Use the common if-else coding style
---
src/providers/ipa/ipa_subdomains_ext_groups.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/providers/ipa/ipa_subdomains_ext_groups.c
b/src/providers/ipa/ipa_subdomains_ext_groups.c
index
5dc6d0d6417ec3fb5e7865e4cbaf3c07f4afbd07..149e5b5dffb53c8403232ce35ac625513c7eeb28
100644
--- a/src/providers/ipa/ipa_subdomains_ext_groups.c
+++ b/src/providers/ipa/ipa_subdomains_ext_groups.c
@@ -80,8 +80,7 @@ static errno_t process_ext_groups(TALLOC_CTX *mem_ctx, size_t
reply_count,
if (ret == ENOENT) {
/* no external members, try next external group. */
continue;
- }
- if (ret != EOK) {
+ } else if (ret != EOK) {
DEBUG(SSSDBG_OP_FAILURE,
"sysdb_attrs_get_string_array failed.\n");
goto done;
@@ -92,8 +91,7 @@ static errno_t process_ext_groups(TALLOC_CTX *mem_ctx, size_t
reply_count,
if (ret == ENOENT) {
/* no IPA groups, try next external group. */
continue;
- }
- if (ret != EOK) {
+ } else if (ret != EOK) {
DEBUG(SSSDBG_OP_FAILURE,
"sysdb_attrs_get_string_array failed.\n");
goto done;
--
2.4.3
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]
