On (02/03/16 13:45), Pavel Reichl wrote: >On 03/02/2016 01:10 PM, Lukas Slebodnik wrote: >>On (02/03/16 13:02), Pavel Reichl wrote: >>>On 03/02/2016 12:53 PM, Lukas Slebodnik wrote: >>>>On (02/03/16 12:48), Pavel Březina wrote: >>>>>On 03/01/2016 03:54 PM, Pavel Reichl wrote: >>>>>>I added one more similar patch. >>>>>> >>>>>>sss_idmap_calculate_range can accept domain SID or range identifier on >>>>>>its input. Previous parameter name was misleading. >>>>> >>>>>Ack to both. They can sure be squashed before pushing but I don't care. >>>>I miss a link here. >>>> >>>>Anyway I would like to see a Sumit opinin about renaming variables. >>>>Because name of variables is one of hard things problems in IT >>>>http://martinfowler.com/bliki/TwoHardThings.html >>> >>>Might we could do an all hands meeting, >>>because we really don't want to underestimate such important change. >>> >>If the patch is not important then it does not make a sense to push it. >> >>BTW You introduced one of bad argument names in the recent >>commit 8babbeee01e67893af4828ddfc922ecac0be4197 > >Sure, I did that and now I see that it would be nice to use a different name. > Sumit is fine with changes. Would you be so kind and could you send squased patch which we can push.
LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
