On (10/03/16 12:54), Pavel Březina wrote: >On 03/08/2016 05:55 PM, Sumit Bose wrote: >>Hi, >> >>This patch fixes a 2FA issues observed with sudo. See commit message for >>details. >> >>bye, >>Sumit >> >> >>0001-pam_sss-reorder-pam_message-array.patch >> >> >> From 2c38adad7b527aceb4f9cb41c7d7b4c66d4580c9 Mon Sep 17 00:00:00 2001 >>From: Sumit Bose<[email protected]> >>Date: Mon, 7 Mar 2016 17:07:16 +0100 >>Subject: [PATCH] pam_sss: reorder pam_message array >> >>There are different expectations about how the pam_message array is >>organized, details can be found in the pam_start man page. E.g. sudo was >>not able to handle the Linux-PAM style but expected the Solaris PAM >>style. With this patch both styles should work as expected. > >I don't see any detail explaining this in the man page... could you elaborate >please? > >>- mesg[0] = (const struct pam_message *) m1; >>- mesg[1] = (const struct pam_message *) m2; >>+ mesg[0] = (const struct pam_message *) m; >>+ mesg[1] = & (( *mesg )[1]); > >Is it possible to use &m[1] instead of this? > Should we ask pam maintainer to review this change?
LS _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
