On (12/04/16 09:58), Lukas Slebodnik wrote: >On (12/04/16 07:50), Petr Cech wrote: >>On 04/11/2016 08:51 AM, Lukas Slebodnik wrote: >>>On (11/04/16 06:34), Petr Cech wrote: >>>>Hello list, >>>> >>>>push/pop global_talloc_context into check_leaks is redudant. It is done >>>>in leak_check_setup() and leak_check_teardown() functions in >>>>src/tests/check_leaks. >>>> >>>>Thanks Pavel Brezina, that showed me it. >>>> >>>>Simple patch is attached. >>>> >>>>Regards >>>> >>>>-- >>>>Petr^4 Čech >>> >>>>From b090aa80e23b33e8f9710412e9453dbcdb6811c5 Mon Sep 17 00:00:00 2001 >>>>From: Petr Cech <[email protected]> >>>>Date: Mon, 11 Apr 2016 00:26:19 -0400 >>>>Subject: [PATCH] REFACTOR: global_talloc_context push/pop remove >>> ^^^^^^^^ >>> We do not have a component "REFACTOR" >>> and our commit template recommends to use component before >>> colon. @see file .git-commit-template in git root. >>> >>>LS >> >>Hello Lukas, >> >>I fixed it, thanks. New patch is attached. >> >>Regards >> >>-- >>Petr^4 Čech > >>From 18f6f6358f91f5082f7bfb1f4e31eafa5e2e8591 Mon Sep 17 00:00:00 2001 >>From: Petr Cech <[email protected]> >>Date: Mon, 11 Apr 2016 00:26:19 -0400 >>Subject: [PATCH] TESTS: global_talloc_context push/pop remove >> >>Push/pop global_talloc_context into check_leaks is redudant. It is done >>in leak_check_setup() and leak_check_teardown() functions in >>src/tests/check_leaks. >>--- >> src/tests/cmocka/test_ad_common.c | 2 -- >> src/tests/cmocka/test_child_common.c | 2 -- >> src/tests/cmocka/test_tools_colondb.c | 2 -- >> src/tests/cmocka/test_utils.c | 4 ---- >> src/tests/cwrap/test_become_user.c | 2 -- >> 5 files changed, 12 deletions(-) >> >ACK > >http://sssd-ci.duckdns.org/logs/job/41/00/summary.html > >LS master: * 2a5cf841dec2785333117a293fcd8c875ace28b9
LS _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
