On (15/04/16 09:29), Sumit Bose wrote:
>Hi,
>
>this patch removes a useless and irritation debug messages.
>
>bye,
>Sumit
>From 156468b36f05966ae74df92309853ddf1f644199 Mon Sep 17 00:00:00 2001
>From: Sumit Bose <sb...@redhat.com>
>Date: Fri, 15 Apr 2016 09:24:06 +0200
>Subject: [PATCH] krb5_auth_store_creds: silence spurious debug message
>
>During a pre-authentication request there are always messages like:
>
>... [krb5_auth_store_creds] (0x0010): unsupported PAM command [249].
>... [krb5_auth_store_creds] (0x0010): password not available, offline auth may
>not work.
>
>This patch removes them.
>---
> src/providers/krb5/krb5_auth.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/src/providers/krb5/krb5_auth.c b/src/providers/krb5/krb5_auth.c
>index
>f86d03a79d0e666e0e4de09a18d0b463ca121912..2761a38f749908d5c296249f1575aed4af03fa20
> 100644
>--- a/src/providers/krb5/krb5_auth.c
>+++ b/src/providers/krb5/krb5_auth.c
>@@ -340,6 +340,10 @@ static void krb5_auth_store_creds(struct sss_domain_info
>*domain,
> * as the cached password.
> */
> break;
>+ case SSS_PAM_PREAUTH:
>+ /* There are no credentials available during pre-authentication,
>+ * nothing to do. */
>+ break;
> case SSS_PAM_AUTHENTICATE:
> case SSS_PAM_CHAUTHTOK_PRELIM:
> if (sss_authtok_get_type(pd->authtok) == SSS_AUTHTOK_TYPE_2FA) {
>@@ -378,7 +382,7 @@ static void krb5_auth_store_creds(struct sss_domain_info
>*domain,
> }
>
> if (password == NULL) {
>- if (pd->cmd != SSS_CMD_RENEW) {
>+ if (pd->cmd != SSS_CMD_RENEW && pd->cmd != SSS_PAM_PREAUTH) {
> DEBUG(SSSDBG_FATAL_FAILURE,
> "password not available, offline auth may not work.\n");
> /* password caching failures are not fatal errors */
ACK
http://sssd-ci.duckdns.org/logs/job/42/27/summary.html
LS
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
