On 04/20/2016 02:16 PM, Jakub Hrozek wrote:
+ for (num = 0, i = 0; i < res->count; i++) { >+ const struct ldb_val *val; >+ char *name; >+ int n; >+ int j;Every time I see variables declared in a scope in C except loop control variables I think "This should be a static function of its own":-)
Yes, and I think it's great that Simo does so, instead of hiding this fact by placing all variables at the beginning of the function. Limiting scope of variables as much as possible is a good think! _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
