Hi,

this patch is about removing redudant debug message from middle layer of autofs responder.

The point is that called function confdb_get_int() has very nice messaging.

Please, look at how we call autofs_get_config, there is another debug message at top level, but this is important because it says that error is fatal.

Regards

--
Petr^4 Čech
>From 545464d563f4aa382b7e177a4fe2ea966ab72c5b Mon Sep 17 00:00:00 2001
From: Petr Cech <pc...@redhat.com>
Date: Thu, 21 Apr 2016 07:32:28 -0400
Subject: [PATCH] AUTOFS: Removing of redudant debug message

Debug message has been doubled.

At a low level, we have a very accurate debug messsage with description
of situation (in confdb_get_int()). At higher level we informe about
the fatal crash, if it happend.
---
 src/responder/autofs/autofssrv.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/responder/autofs/autofssrv.c b/src/responder/autofs/autofssrv.c
index ff30167298e0028da3f14f4d63a4d129c9c70bf0..80762cbc16d0a8048125c7df04ef92c71bc31426 100644
--- a/src/responder/autofs/autofssrv.c
+++ b/src/responder/autofs/autofssrv.c
@@ -64,12 +64,6 @@ autofs_get_config(struct autofs_ctx *actx,
     ret = confdb_get_int(cdb, CONFDB_AUTOFS_CONF_ENTRY,
                          CONFDB_AUTOFS_MAP_NEG_TIMEOUT, 15,
                          &actx->neg_timeout);
-    if (ret != EOK) {
-        DEBUG(SSSDBG_OP_FAILURE, "Cannot read %s from configuration [%d]: %s\n",
-              CONFDB_AUTOFS_MAP_NEG_TIMEOUT, ret, strerror(ret));
-        return ret;
-    }
-
     return EOK;
 }
 
-- 
2.5.5

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

Reply via email to