On 06/17/2016 08:33 PM, Lukas Slebodnik wrote:
On (17/06/16 16:54), Lukas Slebodnik wrote:
On (14/06/16 15:30), Pavel Březina wrote:
On 05/16/2016 02:00 PM, Pavel Březina wrote:
Hi,
the patches are finally ready to be tested and reviewed. It is too huge
to be sent to the list so please checkout my fedorapeople or github repo:
https://fedorapeople.org/cgit/pbrezina/public_git/sssd.git/log/?h=backend
https://github.com/pbrezina/sssd/tree/backend
Subdomain handlers are not yet converted so subdomain support is
disabled, otherwise everything should work although I'm sure you'll find
some bugs.
I managed to do some simple tests (initgroups, authentication) with ldap
provider so far and will continue testing and fixing so if you find a
bug make sure you run with the latest version before reporting it please
:-)
Since the changes touch almost all areas of SSSD I encourage everyone to
run and try. Some handlers were converted quite easily, some took more
handy work. Areas that are most likely to contain some bugs are these
(please give it extra attention):
- proxy provider
- if group membership changes during initgroups, nss memory cache should
be clear through dbus call
- selinux support
- hbac support
- change password
- password migration (ipa)
Don't be alarmed with the number of new lines -- there is not that many
changes. I copied all touched files and suffixed them with _new so sssd
can be compiled and kept working until the latest patches. I also wanted
to keep the original code intact for comparison (it was easier for
development and it may be handy for bug chasing), you can simply use
some diff tool to see the changes. We can squash it in the end.
When I will be confident that the patches are stable I will do some
clean up and remove content that is no longer needed.
Just a quick update: all found bugs were fixed, CI pass, all downstream tests
which were tried (I think all but IPA) pass.
There is a bug in forest user lookup when joined to child domain
I verified that it works on master.
There is a current master installed on machine which
I gave you. Try to copmare results with your branch
BTW your patch with braces in debug messages
remind me to check missing new lines in your patches.
@see attached diff
and please also clean test directories after successful tests.
@see attached diff
LS
Thank you.
Diffs were squashed and forest user look up was fixed (I used basedn
from sssd domain instead of forest).
I also removed suffix from new files and merged the content with the old
ones. Since the review process is near the end and this way it will keep
git blame and nicer history.
I added also rdp_message.c (rdp stands for resp. dp.) to simplify all
communication with data provider from responders, now it's just pure
tevent request. Later I'd like to extend it to support request grouping
like we do today and create a more extensible and tevent-only dp
interface for responders that would not depend on the output triplet
(ret, dperror, msg) and allowed custom output data. But there's still
time for this.
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
