ehlo, python3.5 CFLAGS contains warning Wsign-compare and file confdb_setup.c was added to SSSD_TOOLS_OBJ which is required for python3-sss (pysss.so)
python3.5 is on debian >= testing and fedora 24+ LS
>From 6b8ec1214ea14fd608202c01f2c2f1f1cb98536e Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <[email protected]> Date: Fri, 1 Jul 2016 08:46:20 +0200 Subject: [PATCH] Fix warning sign-compare python3.5 CFLAGS contains warning Wsign-compare and file confdb_setup.c was added to SSSD_TOOLS_OBJ which is required for python3-sss (pysss.so) src/confdb/confdb_setup.c: In function 'confdb_purge': src/confdb/confdb_setup.c:95:15: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for(i=0; i<res->count; i++) { ^ src/confdb/confdb_setup.c: In function 'confdb_init_db': src/confdb/confdb_setup.c:219:25: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if (ret <= 0 || ret >= sizeof(timestr)) { ^ cc1: all warnings being treated as errors --- src/confdb/confdb_setup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/confdb/confdb_setup.c b/src/confdb/confdb_setup.c index 09b6fee0da519e8296b0d02b766392a265472a3a..d6feab9000d54d2c3761de6d8e990053ade7e85f 100644 --- a/src/confdb/confdb_setup.c +++ b/src/confdb/confdb_setup.c @@ -74,7 +74,8 @@ static int confdb_test(struct confdb_ctx *cdb) static int confdb_purge(struct confdb_ctx *cdb) { - int ret, i; + int ret; + unsigned int i; TALLOC_CTX *tmp_ctx; struct ldb_result *res; struct ldb_dn *dn; @@ -216,7 +217,7 @@ static int confdb_init_db(const char *config_file, const char *config_dir, errno = 0; ret = sss_ini_get_mtime(init_data, sizeof(timestr), timestr); - if (ret <= 0 || ret >= sizeof(timestr)) { + if (ret <= 0 || ret >= (int)sizeof(timestr)) { DEBUG(SSSDBG_FATAL_FAILURE, "Failed to convert time_t to string ??\n"); ret = errno ? errno : EFAULT; -- 2.7.4
_______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
