On (07/07/16 13:05), Pavel Březina wrote: >On 06/30/2016 03:37 PM, Lukas Slebodnik wrote: >> On (30/06/16 09:28), Sumit Bose wrote: >> > On Wed, Jun 29, 2016 at 11:23:55PM +0200, Jakub Hrozek wrote: >> > > Hi, >> > > I pushed the attached patch under the one-liner rule (which I'm not a >> > > big fan of, but it's late and I've been wanting to do this release for >> > > almost a week..) >> > > >> > > I hope it's OK with everybody. I added a silly RB to satisfy our git >> > > hook. >> > >> > Thank you for catching this. The patch makes sense and looks good by >> > careful visual inspection. So afterwards-ACK. >> > >> > bye, >> > Sumit >> > >> > > From 1dab34228cefddcd6bedef2d2cee70a620c8ace8 Mon Sep 17 00:00:00 2001 >> > > From: Jakub Hrozek <[email protected]> >> > > Date: Wed, 29 Jun 2016 23:16:54 +0200 >> > > Subject: [PATCH] MAN: Include idmap_sss.8.xml in the manpage sources >> > > >> > > Reviewed-by: N/A, one-liner before release >> > > --- >> > > src/man/po/po4a.cfg | 1 + >> > > 1 file changed, 1 insertion(+) >> > > >> > > diff --git a/src/man/po/po4a.cfg b/src/man/po/po4a.cfg >> > > index >> > > 6dbf11906164e1601964b2e434bfef49455ef17e..ca9d66a2a616f4ced179fb78edf50f94b77dcec3 >> > > 100644 >> > > --- a/src/man/po/po4a.cfg >> > > +++ b/src/man/po/po4a.cfg >> > > @@ -26,6 +26,7 @@ >> > > [type:docbook] sss_rpcidmapd.5.xml >> > > $lang:$(builddir)/$lang/sss_rpcidmapd.5.xml >> > > [type:docbook] sss_ssh_authorizedkeys.1.xml >> > > $lang:$(builddir)/$lang/sss_ssh_authorizedkeys.1.xml >> > > [type:docbook] sss_ssh_knownhostsproxy.1.xml >> > > $lang:$(builddir)/$lang/sss_ssh_knownhostsproxy.1.xml >> > > +[type:docbook] idmap_sss.8.xml $lang:$(builddir)/$lang/idmap_sss.8.xml >> > > [type:docbook] include/service_discovery.xml >> > > $lang:$(builddir)/$lang/include/service_discovery.xml opt:"-k 0" >> > > [type:docbook] include/upstream.xml >> > > $lang:$(builddir)/$lang/include/upstream.xml opt:"-k 0" >> > > [type:docbook] include/failover.xml >> > > $lang:$(builddir)/$lang/include/failover.xml opt:"-k 0" >> > > -- >> > > 2.4.11 >> > > >> > >> It happened more time that we forgot to add man page there. >> Maybe it would be good to write a test. (bash script should be enough) >> We already have a test to check traling whitestapces >> src/tests/whitespace_test. > >Instead of writing a test, it would be better to write a script to generate >po4a.cfg imho. > That's good idea as well.
LS _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
