Hello list,
there is simple patch for [1].
I prepared two version:
a) the first is for changing the message,
b) the second is for removing.
I looked at the code -- I think it could be useful to know what type of
direction we have. But I agree that it could be really confusing if we
see 'trust direction not set'.
So I vote for removing.
Please do you have any other opinion?
[1] https://fedorahosted.org/sssd/ticket/3090
Regards
--
Petr^4 Čech
>From c00336a3eee9472f7649ceea52bc0c0df3c0988b Mon Sep 17 00:00:00 2001
From: Petr Cech <[email protected]>
Date: Tue, 12 Jul 2016 10:03:56 +0200
Subject: [PATCH] IPA: Changing of confusing debug message
This debug message used to confuse our users. So this patch changes it.
Resolves:
https://fedorahosted.org/sssd/ticket/3090
---
src/providers/ipa/ipa_subdomains.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c
index a02a65d97dde68f1da900b9fdca05c54035ce005..9647c3e1ce0bbce86008d0941c416476ac541918 100644
--- a/src/providers/ipa/ipa_subdomains.c
+++ b/src/providers/ipa/ipa_subdomains.c
@@ -426,8 +426,8 @@ static errno_t ipa_subdom_store(struct sss_domain_info *parent,
goto done;
}
- DEBUG(SSSDBG_FUNC_DATA,
- "Trust direction of %s is %s\n", name, ipa_trust_dir2str(direction));
+ DEBUG(SSSDBG_FUNC_DATA, "Trust direction type of [%s] is [%s]\n",
+ name, ipa_trust_dir2str(direction));
ret = sysdb_subdomain_store(parent->sysdb, name, realm, flat,
id, mpg, enumerate, forest,
direction);
--
2.7.4
>From ec442dbbc44b7e075f4dcaff3a5c58c44e7df8f8 Mon Sep 17 00:00:00 2001
From: Petr Cech <[email protected]>
Date: Tue, 12 Jul 2016 10:11:16 +0200
Subject: [PATCH] IPA: Removing of confusing debug message
This debug message used to confuse our users. So this patch removes it.
Resolves:
https://fedorahosted.org/sssd/ticket/3090
---
src/providers/ipa/ipa_subdomains.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c
index a02a65d97dde68f1da900b9fdca05c54035ce005..95a696d845bd9bb0ad34bdf8879be54fd39290e0 100644
--- a/src/providers/ipa/ipa_subdomains.c
+++ b/src/providers/ipa/ipa_subdomains.c
@@ -426,8 +426,6 @@ static errno_t ipa_subdom_store(struct sss_domain_info *parent,
goto done;
}
- DEBUG(SSSDBG_FUNC_DATA,
- "Trust direction of %s is %s\n", name, ipa_trust_dir2str(direction));
ret = sysdb_subdomain_store(parent->sysdb, name, realm, flat,
id, mpg, enumerate, forest,
direction);
--
2.7.4
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]
