On 07/12/2016 01:15 PM, Pavel Březina wrote:
On 07/12/2016 12:34 PM, Michal Židek wrote:
      state->ipa_ctx->dyndns_ctx->last_refresh = time(NULL);

LGTM but maybe we should place the check before this line?

Not sure... I only added checks for the line with strcmp
(which is where it segfaulted). If I moved
it up where you suggest, there would be the question why
I do not check for example ipa_ctx or ipa_ctx->dyndns_ctx.

But if you prefer having it there I can do it, but will
also add a comment that the checks are relevant for the
strcmp line.

Michal


_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to