On (20/07/16 16:33), Nikolai Kondrashov wrote:
>Hi Jakub,
>
>Thanks for your swift response :)!
>
>On 07/20/2016 04:17 PM, Jakub Hrozek wrote:
>> On Wed, Jul 20, 2016 at 03:53:54PM +0300, Nikolai Kondrashov wrote:
>> better: If a developer works on a module that is confusing to
>> understand, document the code flow.
>
>And here is the pitfall: the author is the one least qualified to judge how
>confusing the code is, because he/she already groks it. I'm not saying it's
>impossible, but bias would be expected.
>
Therefore we have a review.
If reviewer does not understand the code then the code should be changed.
Documentation will not help.

+ @see my other response about unit test.

LS
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to