So, sorry for the very long title and please, see the proposed patches for solving https://fedorahosted.org/sssd/ticket/3094
Best Regards, -- Fabiano Fidêncio
From 7b04832fce0bdf7f8e86c30f60811f7d219e62fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <[email protected]> Date: Tue, 2 Aug 2016 15:04:51 +0200 Subject: [PATCH 1/3] RESPONDERS: Decrease debug level for failures in SELINUX_getpeercon() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As this is not FATAL and may happen when SELinux is disabled, let's just decrease the debug level to MINOR_FAILURE Signed-off-by: Fabiano Fidêncio <[email protected]> Related: https://fedorahosted.org/sssd/ticket/3094 --- src/responder/common/responder_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c index 7f6264a..e7590bc 100644 --- a/src/responder/common/responder_common.c +++ b/src/responder/common/responder_common.c @@ -128,8 +128,8 @@ static errno_t get_client_cred(struct cli_ctx *cctx) ret = SELINUX_getpeercon(cctx->cfd, &secctx); if (ret != 0) { - DEBUG(SSSDBG_CRIT_FAILURE, - "SELINUX_getpeercon failed [%d][%s].\n", ret, strerror(ret)); + DEBUG(SSSDBG_MINOR_FAILURE, + "SELINUX_getpeercon failed [%d][%s].\n" /* This is not fatal, as SELinux may simply be disabled */ ret = EOK; } else { -- 2.7.4
From ac7d4a7e6dfaf5d6c08419452b36937ac01453be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <[email protected]> Date: Tue, 2 Aug 2016 15:08:09 +0200 Subject: [PATCH 2/3] RESPONDERS: Show a bit more info in case of SELINUX_getpeercon() failure MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Be explicit that it may happen when SELinux is disabled and also suggest to enable SELinux. Signed-off-by: Fabiano Fidêncio <[email protected]> Related: https://fedorahosted.org/sssd/ticket/3094 --- src/responder/common/responder_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c index e7590bc..8d9499d 100644 --- a/src/responder/common/responder_common.c +++ b/src/responder/common/responder_common.c @@ -129,7 +129,9 @@ static errno_t get_client_cred(struct cli_ctx *cctx) ret = SELINUX_getpeercon(cctx->cfd, &secctx); if (ret != 0) { DEBUG(SSSDBG_MINOR_FAILURE, + "The following failure is expected to happen in case SELinux is disabled:\n" "SELINUX_getpeercon failed [%d][%s].\n" + "Please, consider enabling SELinux in your system.\n", ret, strerror(ret)); /* This is not fatal, as SELinux may simply be disabled */ ret = EOK; } else { -- 2.7.4
From 8d595daa03b2a8af1605744cd19d5000a9546456 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <[email protected]> Date: Tue, 2 Aug 2016 15:12:45 +0200 Subject: [PATCH 3/3] RESPONDERS: Pass errno to strerror() when SELINUX_getpeercon() fails MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently ret, which is -1, is passed to strerror() instead of errno. Signed-off-by: Fabiano Fidêncio <[email protected]> Related: https://fedorahosted.org/sssd/ticket/3094 --- src/responder/common/responder_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c index 8d9499d..a3ad9ad 100644 --- a/src/responder/common/responder_common.c +++ b/src/responder/common/responder_common.c @@ -131,7 +131,7 @@ static errno_t get_client_cred(struct cli_ctx *cctx) DEBUG(SSSDBG_MINOR_FAILURE, "The following failure is expected to happen in case SELinux is disabled:\n" "SELINUX_getpeercon failed [%d][%s].\n" - "Please, consider enabling SELinux in your system.\n", ret, strerror(ret)); + "Please, consider enabling SELinux in your system.\n", ret, strerror(errno)); /* This is not fatal, as SELinux may simply be disabled */ ret = EOK; } else { -- 2.7.4
_______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
