On (04/08/16 12:13), Michal Židek wrote:
>On 07/27/2016 03:13 PM, Petr Cech wrote:
>> On 07/27/2016 03:05 PM, Petr Cech wrote:
>> > On 07/27/2016 02:32 PM, Michal Židek wrote:
>> > > Hi,
>> > >
>> > > I believe that this patch makes pinpointing
>> > > of config errors a little easier. Especially
>> > > when using sssctl tool that currently refuses
>> > > to start a command when there are syntax errors in
>> > > sssd.conf, but by default it does not print
>> > > problematic line number. Compare:
>> > >
>> > > ldb: unable to dlopen /usr/lib64/ldb/modules/ldb/memberof.la :
>> > > /usr/lib64/ldb/modules/ldb/memberof.la: invalid ELF header
>> > > (Wed Jul 27 14:05:39:185114 2016) [sssd] [sss_ini_get_config] (0x0010):
>> > > Failed to parse configuration. Error 5.
>> > > (Wed Jul 27 14:05:39:185192 2016) [sssd] [sss_ini_get_config] (0x0010):
>> > > Errors detected while parsing: /etc/sssd/sssd.conf
>> > > (Wed Jul 27 14:05:39:185229 2016) [sssd] [confdb_init_db] (0x0010):
>> > > Failed to load configuration
>> > > (Wed Jul 27 14:05:39:185255 2016) [sssd] [confdb_setup] (0x0010): ConfDB
>> > > initialization has failed [5]: Input/output error
>> > > (Wed Jul 27 14:05:39:185288 2016) [sssd] [sss_tool_confdb_init]
>> > > (0x0010): Unable to setup ConfDB [5]: Input/output error
>> > >
>> > >
>> > > and:
>> > >
>> > > ldb: unable to dlopen /usr/lib64/ldb/modules/ldb/memberof.la :
>> > > /usr/lib64/ldb/modules/ldb/memberof.la: invalid ELF header
>> > > (Wed Jul 27 14:22:51:096949 2016) [sssd] [sss_ini_get_config] (0x0010):
>> > > Failed to parse configuration. Error 5.
>> > > (Wed Jul 27 14:22:51:097173 2016) [sssd] [sss_ini_get_config] (0x0010):
>> > > Errors detected while parsing: /etc/sssd/sssd.conf
>> > > (Wed Jul 27 14:22:51:097490 2016) [sssd] [sss_ini_config_print_errors]
>> > > (0x0010): Error (2) on line 10: No closing bracket.
>> > > (Wed Jul 27 14:22:51:097946 2016) [sssd] [confdb_init_db] (0x0010):
>> > > Failed to load configuration
>> > > (Wed Jul 27 14:22:51:098452 2016) [sssd] [confdb_setup] (0x0010): ConfDB
>> > > initialization has failed [5]: Input/output error
>> > > (Wed Jul 27 14:22:51:098651 2016) [sssd] [sss_tool_confdb_init]
>> > > (0x0010): Unable to setup ConfDB [5]: Input/output error
>> > >
>> > > Patch is attached.
>> > >
>> > > Michal
>> >
>> > Hi Michal,
>> >
>> > thanks for your patch. It looks good to me.
>> >
>> > => LGTM
>> >
>> > I think I should run tests only locally for such simple patch. Please,
>> > wait a moment.
>>
>> CI locally passed.
>>
>> => ACK
>>
>> Regards
>>
>
>This was already acked. Can we push it?
>
man sssd.conf says:
0, 0x0010: Fatal failures. Anything that would prevent SSSD from
starting up or causes it to cease running.
Are you sure that validation warnings match this descriptions?
LS
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
