ehlo, attached is a oneliner for bug introduced in dc30c60f166ad9adc63a47a1013508a71624ac87
I would push the patch with oneliner rule but there were objection in past for such behaviour. It was recommended to to use only in "critical" situation before release. LS
>From 48b71bb0b1012f5e1830b8ec359ed60171b935b4 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <[email protected]> Date: Mon, 8 Aug 2016 09:03:47 +0200 Subject: [PATCH] LDAP: Fix Dereference after NULL check The commit dc30c60f166ad9adc63a47a1013508a71624ac87 changed the logic in NULL check - if (protocol) { + if (protocol == NULL) { Found by Coverity: --- src/providers/ldap/ldap_id_services.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/providers/ldap/ldap_id_services.c b/src/providers/ldap/ldap_id_services.c index e91fc52d731eaa22be7e98365fc75e7057cb8f1f..638cb619b39f135307090dcf0f2c6ab2cc4119d0 100644 --- a/src/providers/ldap/ldap_id_services.c +++ b/src/providers/ldap/ldap_id_services.c @@ -114,7 +114,7 @@ services_get_send(TALLOC_CTX *mem_ctx, ret = sss_filter_sanitize(state, name, &clean_name); if (ret != EOK) goto error; - if (protocol == NULL) { + if (protocol != NULL) { ret = sss_filter_sanitize(state, protocol, &clean_protocol); if (ret != EOK) goto error; } -- 2.9.2
_______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
