On (10/08/16 08:11), Lukas Slebodnik wrote:
>On (10/08/16 08:09), Lukas Slebodnik wrote:
>>ehlo,
>>
>>yesterdat, I build a sssd in copr for various distributions
>>and the dyndns-tests failed for me few time.
>>We had a similar failures also in CI
>>http://sssd-ci.duckdns.org/logs/job/50/54/fedora_rawhide/ci-build-coverage/dyndns-tests.log
>>
>>Attached patch should fix it.
>>
>And now with a subject :-)
>
And hopefully, the last version without debug information used
for troubleshooting.

LS
>From 0cfba20a97d034d75f174f83ad44fd4883e1f5b2 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <[email protected]>
Date: Wed, 10 Aug 2016 07:44:28 +0200
Subject: [PATCH] dyndns-tests: Fix false positive failures

The child process finished faster then it has handled by parent
and therefore it timed out. It's the similar solution as in
b3074dca3acebd91437ef13d3329d6d65d655215

[ RUN      ] dyndns_test_error
(Fri Jul 29 16:12:00:621444 2016) [sssd] [nsupdate_child_timeout] (0x0020):
  Timeout reached for dynamic DNS update
Could not run the test - check test fixtures
[  ERROR   ] dyndns_test_error
---
 src/tests/cmocka/test_dyndns.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/tests/cmocka/test_dyndns.c b/src/tests/cmocka/test_dyndns.c
index 
b8404ef1018c1ec9720e506807bcf3f3df379a2d..fafd4d8a595cc608447d4068eeb0cee2ba819d89
 100644
--- a/src/tests/cmocka/test_dyndns.c
+++ b/src/tests/cmocka/test_dyndns.c
@@ -75,6 +75,7 @@ void __wrap_execv(const char *path, char *const argv[])
         case MOCK_NSUPDATE_ERR:
             DEBUG(SSSDBG_FUNC_DATA, "nsupdate error test case\n");
             err = 1;
+            usleep(50000); /* 50 miliseconds */
             break;
         case MOCK_NSUPDATE_TIMEOUT:
             DEBUG(SSSDBG_FUNC_DATA, "nsupdate timeout test case\n");
-- 
2.9.2

_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to