On Mon, Aug 15, 2016 at 4:05 PM, Jakub Hrozek <[email protected]> wrote: > On Mon, Aug 15, 2016 at 04:01:13PM +0200, Jakub Hrozek wrote: >> Hi, >> >> attached are three small but important patches related to sssd-secrets. >> The context is that I started to write tests and manpage for >> sssd-secrets and noticed some issues. I hope the patches themselves >> offer a nice commit message. >> >> To test the socket activation, you can just install the RPMs built with >> these patches and call the socket responder, for example: >> curl -H "Content-Type: application/json" \ >> --unix-socket /var/run/secrets.socket \ >> -XGET http://localhost/secrets/ >> >> (You can see more examples in the WIP manpage at: >> https://github.com/jhrozek/sssd/commit/508c9eec040cada06bc6a61fe200f2db20a0735b) >> >> If these patches are accepted, I'll also amend the manpage to list the >> service and the socket. >> >> btw it occured to me we might want to support service self-termination, >> but I would prefer to do that in another patchset and tracked with a >> ticket. > > Let's try it with the patches actually.. > > _______________________________________________ > sssd-devel mailing list > [email protected] > https://lists.fedorahosted.org/admin/lists/[email protected] >
Patchs 0001 and 0002 look good to me. About the patch 0003, it has a commit message typo (s/acticate/activate). By a simple review it looks good to me but, sincerely, I'd like to have someone else to review it as well (I'll do the tests later on ...). Best Regards, -- Fabiano Fidêncio _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
