On 08/17/2016 09:17 AM, Justin Stephenson wrote: > > On 08/17/2016 07:34 AM, Lukas Slebodnik wrote: >> On (16/08/16 09:57), Justin Stephenson wrote: >>> Thanks for the info, yes please go ahead and squash them. >>> >>> Kind regards, >>> Justin Stephenson >>> >>> On 08/16/2016 09:32 AM, Jakub Hrozek wrote: >>>> On Fri, Aug 12, 2016 at 11:26:15AM -0400, Justin Stephenson wrote: >>>>> code patch and man page attached, also added the PATCH: prefix to the >>>>> commit >>>>> message for the code patch. >>>> You don't have to add the PATCH prefix, git adds that automatically when >>>> you format the patch with "git format-patch". >> We have a basic template fot git commit messages. >> But It need to be enabled by developer. >> e.g. git config commit.template .git-commit-template >> https://git.fedorahosted.org/cgit/sssd.git/commit/?id=3d9edb4c510028def2df41aa7b0ce705b197e6fc >> >> >> BTW Michal recently updated our contribution wiki page >> and information about git commit template is already there :-) >> https://fedorahosted.org/sssd/wiki/Contribute > Thanks Lukas, I applied the git commit template but is there a list of > Components somewhere that we would decide to choose from? >
It's not formal, it's mostly a hint. In this case, I'd use either "Monitor:" or "Netlink:" for the component. > Let me know if I need to clean anything else up for this patch. I was going to > squash the commits together but there are other commits in between these two > in > my interactive rebase, perhaps I just need to reorder them then squash? > > Kind regards, > Justin Stephenson >> >> LS >> _______________________________________________ >> sssd-devel mailing list >> [email protected] >> https://lists.fedorahosted.org/admin/lists/[email protected] > _______________________________________________ > sssd-devel mailing list > [email protected] > https://lists.fedorahosted.org/admin/lists/[email protected]
signature.asc
Description: OpenPGP digital signature
_______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
