On (17/08/16 16:23), Jakub Hrozek wrote:
>On Wed, Aug 17, 2016 at 03:41:29PM +0200, Jakub Hrozek wrote:
>> On Wed, Aug 17, 2016 at 01:16:48PM +0200, Petr Cech wrote:
>> > @@ -379,7 +394,12 @@ static void sdap_get_tgt_done(struct tevent_req
>> > *subreq)
>> >
>> > sdap_close_fd(&state->child->io->read_from_child_fd);
>> >
>> > - tevent_req_done(req);
>> > + if (state->kill_te == NULL) {
>> > + tevent_req_done(req);
>> > + return;
>> > + }
>> > +
>> > + // wait for child callback to terminate the request
>>
>> Please don't use C++ commments in SSSD code. Since this is the only
>> comment, I can convert to a C-style comments before pushing.
>
"//" is not just a c++ style comment. IIRC It's part of c99
However, it's not recommended(or even prohibited)
by our coding style guide :-)
LS
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
