On Wed, Aug 24, 2016 at 11:55 AM, Pavel Březina <pbrez...@redhat.com> wrote: > On 08/24/2016 11:41 AM, Fabiano Fidêncio wrote: >> >> On Wed, 2016-08-24 at 11:29 +0200, Pavel Březina wrote: >> >>> From 09e5ad3448694d9609bd2a9e89e8a05ef82f66bc Mon Sep 17 00:00:00 >> >> 2001 >>> >>> From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrez...@redhat.com> >>> Date: Mon, 22 Aug 2016 13:15:04 +0200 >>> Subject: [PATCH] watchdog: cope with time shift >>> >>> Resolves: >>> https://fedorahosted.org/sssd/ticket/3154 >> >> >> May I ask you to be a bit more verbose in the commit message, please? > > > Sure. > >> >>> --- >>> src/util/util_watchdog.c | 41 >> >> +++++++++++++++++++++++++++++++++++++++++ >>> >>> 1 file changed, 41 insertions(+) >>> >>> diff --git a/src/util/util_watchdog.c b/src/util/util_watchdog.c >>> index >> >> 5032fddba1b94b3fc7e560162c392dfa57d699cf..178ff92d5c6b950d0086204012354 >> 74499ba595d 100644 >>> >>> --- a/src/util/util_watchdog.c >>> +++ b/src/util/util_watchdog.c >>> @@ -29,8 +29,39 @@ struct watchdog_ctx { >>> struct timeval interval; >>> struct tevent_timer *te; >>> volatile int ticks; >>> + >>> + /* To detect time shift. */ >>> + struct tevent_context *ev; >>> + int input_interval; >>> + time_t timestamp; >>> } watchdog_ctx; >>> >>> +bool watchdog_detect_timeshift(void) >> >> >> This function may be static, as it's not used anywhere out of this >> file. > > > Yep. > >> Patch looks good to me apart from the minor comments. > > > Thank you, new patch is attached.
I didn't run any tests (neither CI or make check), but I assume you will before pushing the patch. Acked-by: Fabiano Fidêncio <fiden...@redhat.com> Best Regards, -- Fabiano Fidêncio _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
