On Mon, Sep 05, 2016 at 02:31:31PM +0200, Fabiano Fidêncio wrote: > On Mon, Sep 5, 2016 at 11:59 AM, Fabiano Fidêncio <fiden...@redhat.com> wrote: > > Petr, > > > > I went through your patches and in general they look good to me. > > However, I haven't done any tests yet with your patches (and I'll do > > it after lunch). > > I've done some tests and I've been able to see the ldif changes in the > domain log. So, I assume it's working. > For sure it's a good improvement! Would be worth to link some > documentation about ldiff as it may be confusing for someone who is > not used to it. > > I'll wait for a new version of the patches and go through them again. > > I really would like to have someone's else opinion on this series.
I quickly scrolled through the patches and the primary thing I don't understand is why are the wrappers used only in sysdb? I think we should just use them everywhere.. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
