URL: https://github.com/SSSD/sssd/pull/27
Title: #27: Minor code changes

lslebodn commented:
"""
NACK to the first patch.
We should rather use ldap_err2string.
Adding more if/else statementes just complicate the code.

the 2nd patch would make sense if you would like to reuse
enum for other use-case which I cannot see in patch set.
If there is not such use-case I would prefer to keep curret name of enum.

LS

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/27#issuecomment-247604790
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to