URL: https://github.com/SSSD/sssd/pull/26
Title: #26: KRB5: Fixing FQ name of user in krb5_setup()

lslebodn commented:
"""
the following change looks werd to me
`-    dbus_free_string_array(arr_object_path);`
`+    dbus_free_string_array(discard_const(arr_object_path));`

What about following change
`@@ -673,8 +674,8 @@ START_TEST(test_marshal_basic_types)`
`     dbus_int64_t v_int64[] = { INT64_C(-6666666666666666), 
INT64_C(7777777777777777) };`
`     dbus_uint64_t v_uint64[] = { UINT64_C(7777777777777777), 
INT64_C(888888888888888888) };`
`     double v_double[] = { 1.1, 2.2, 3.3 };`
`-    char *v_string[] = { "bears", "bears", "bears" };`
`-    char *v_object_path[] = { "/original", "/original" };`
`+    const char *v_string[] = { "bears", "bears", "bears" };`
`+    const char *v_object_path[] = { "/original", "/original" };`

`     unsigned char *arr_byte = v_byte;`
`     dbus_int16_t *arr_int16 = v_int16;`
`@@ -684,8 +685,8 @@ START_TEST(test_marshal_basic_types)`
`     dbus_int64_t *arr_int64 = v_int64;`
`     dbus_uint64_t *arr_uint64 = v_uint64;`
`     double *arr_double = v_double;`
`-    char **arr_string = v_string;`
`-    char **arr_object_path = v_object_path;`
`+    char **arr_string = discard_const_p(char *, v_string);`
`+    char **arr_object_path = discard_const_p(char *, v_object_path);`

BTW the current order of patches would break bisec.
the 1st patch should contain fixes in sbus testa
and then shoudl be added AM_CFLAGS

LS

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/26#issuecomment-247964501
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to