URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

jhrozek commented:
"""
On Mon, Sep 19, 2016 at 05:08:51AM -0700, lslebodn wrote:
> On (19/09/16 04:39), Jakub Hrozek wrote:
> >On Mon, Sep 19, 2016 at 04:21:08AM -0700, celestian wrote:
> >> Well,
> >> 
> >> LGTM. In my opinion we do not have to run CI again for removing of comment.
> >> 
> >> One last point. Jakub, please, could you fix the commit message? It is not 
> >> due to our template how Lukas pointed out in mail.
> >
> >What is wrong with the commit message? it points to a ticket and
> >provides some verbose explanation..
> >
> There are extra spaces before URL.
> 
> Try to look into out git commit template
> sh$ cat .git-commit-template
> COMPONENT: Subject
> 
> Explanation
> 
> Resolves:
> https://fedorahosted.org/sssd/ticket/XXXX
> 
> # Try to keep the subject line within 52 chars ----|
> # Also please try to not exceed 72 characters of length for the body --|
> 
> And also try too lok into commit message ot patch
> when it was introduced 3d9edb4c510028def2df41aa7b0ce705b197e6fc

OK, third attempt at passing review of commit message.

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/25#issuecomment-247980318
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to