URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

lslebodn commented:
On (20/09/16 04:09), Jakub Hrozek wrote:
>I was getting random failures where the socket was not yet ready without
>the sleep, like this:
>    ConnectionError: ('Connection aborted.', error(2, 'No such file or
>    directory'))
>I think the test was just too fast. I pushed a new version that instead
>tries to connect to the socket and waits 0.2 sec if it cannot. The test
>gives up after a second.
Active checking of socket is much better approach.
I think you forgot to close socket :-)

I would also appreciate smaller waits (0.1 or even 0.05)
it's up to you.



See the full comment at 
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to