URL: https://github.com/SSSD/sssd/pull/30
Title: #30: sssctl: use systemd D-Bus API
jhrozek commented:
"""
Looks like there are some warnings:
```
Error: UNINIT (CWE-457):
sssd-1.14.2/src/tools/sssctl/sssctl_systemd.c:60: var_decl: Declaring variable
"msg" without initializer.
sssd-1.14.2/src/tools/sssctl/sssctl_systemd.c:102: uninit_use: Using
uninitialized value "msg".
# 100|
# 101| done:
# 102|-> if (msg != NULL) {
# 103| dbus_message_unref(msg);
# 104| }
Error: COMPILER_WARNING:
sssd-1.14.2/src/tools/sssctl/sssctl_systemd.c: scope_hint: In function
'sssctl_systemd_call'
sssd-1.14.2/src/tools/sssctl/sssctl_systemd.c:102:8: warning: 'msg' may be used
uninitialized in this function [-Wmaybe-uninitialized]
# if (msg != NULL) {
# ^
# 100|
# 101| done:
# 102|-> if (msg != NULL) {
# 103| dbus_message_unref(msg);
# 104| }
Error: UNINIT (CWE-457):
sssd-1.14.2/src/tools/sssctl/sssctl_systemd.c:59: var_decl: Declaring variable
"reply" without initializer.
sssd-1.14.2/src/tools/sssctl/sssctl_systemd.c:106: uninit_use: Using
uninitialized value "reply".
# 104| }
# 105|
# 106|-> if (reply != NULL) {
# 107| dbus_message_unref(reply);
# 108| }
Error: COMPILER_WARNING:
sssd-1.14.2/src/tools/sssctl/sssctl_systemd.c:106:8: warning: 'reply' may be
used uninitialized in this function [-Wmaybe-uninitialized]
# if (reply != NULL) {
# ^
# 104| }
# 105|
# 106|-> if (reply != NULL) {
# 107| dbus_message_unref(reply);
# 108| }
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/30#issuecomment-249536130
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
