URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed

lslebodn commented:
"""
> Great, the result is the same. Both patches could fix it. So we can use just 
> ldap patch.

What do you mean by both patches could fix it?

I aplied just a memboerof patch + test
```
git log --oneline -3
1cde694 TESTS: Adding intg. tests on nested groups
5a9c686 MEMBEROF: Don't resolve members if they are removed
761515e sssctl: call service with absolute path
```

and test failed
```
make -C src/tests/intg intgcheck-installed INTGCHECK_PYTEST_ARGS=" -k 
test_ldap.py"
//snip
test_ldap.py::test_user_2307bis_nested_groups PASSED
test_ldap.py::test_special_characters_in_names PASSED
test_ldap.py::test_extra_attribute_already_exists PASSED
test_ldap.py::test_add_user_to_group PASSED
test_ldap.py::test_remove_user_from_group FAILED
test_ldap.py::test_remove_user_from_nested_group FAILED

================================================ FAILURES 
================================================
______________________________________ test_remove_user_from_group 
_______________________________________
Traceback (most recent call last):
  File "src/tests/intg/test_ldap.py", line 877, in test_remove_user_from_group
    ent.assert_group_by_name("group1", dict(mem=ent.contains_only()))
  File "src/tests/intg/ent.py", line 377, in assert_group_by_name
    assert not d, d
AssertionError: member list mismatch: 
unexpected members found:
['user1']
___________________________________ test_remove_user_from_nested_group 
___________________________________
Traceback (most recent call last):
  File "src/tests/intg/test_ldap.py", line 953, in 
test_remove_user_from_nested_group
    dict(mem=ent.contains_only()))
  File "src/tests/intg/ent.py", line 377, in assert_group_by_name
    assert not d, d
AssertionError: member list mismatch: 
unexpected members found:
['user1']
================================ 102 tests deselected by '-ktest_ldap.py' 
================================
========================== 2 failed, 15 passed, 102 deselected in 46.02 seconds 
==========================
Makefile:728: recipe for target 'intgcheck-installed' failed
make: *** [intgcheck-installed] Error 1
make: Leaving directory 'intg/bld/src/tests/intg'
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/13#issuecomment-253772653
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to