URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains (1.15)
jhrozek commented: """ On Thu, Oct 27, 2016 at 03:56:21AM -0700, Pavel Březina wrote: > pbrezina requested changes on this pull request. > > Hi, there is one indentation which can be simply fixed. Patches works so I > can ack them. > > However, there is something that surprises me. If you set `case_sensitive = > preserving`, I would expect `sss_get_cased_name()` to return the original > format of the name. If this was true than you would have to also transform > `username` to lower in `sysdb_sudo_filter_userinfo()`. So before pushing > these patch: is this correct behaviour of `sss_get_cased_name()`? I agree this should be checked, but if I remember correctly, at least since 1.14 we should always use the lowercased name internally, but when formatting the output name in the NSS responder we should use the original case with a preserving domain. """ See the full comment at https://github.com/SSSD/sssd/pull/43#issuecomment-256685401
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
