URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too
sumit-bose commented: """ There is a slight change in the logic in the first patch. If two entries were found (which should never happen) an error was returned immediately. After refactoring the next matching scheme is tried. Since the next matching scheme should include the results from the one before and error is still returned in the end but some additional cycles are spend. This can be changed by not only returning 'result' but an error code as well. But given the low probability that this kind of error will happen at all I'm not insisting here. In the second patch a comment would be nice explaining why it is sufficient to pick the first search base (because the search bases for a single domain in AD would always have the same DC components). """ See the full comment at https://github.com/SSSD/sssd/pull/49#issuecomment-257552210
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
