URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder
lslebodn commented: """ On (08/11/16 05:15), fidencio wrote: >@jhrozek: >For the first patch the tests are correct. @lslebodn also complained that >[secrets/users/] could be a valid case in the way the code is in git right now >and it's also fixed by my patch. In any case, seems that we don't allow any >config section to end with "/". > >For the second test, I guess that good tests are adding configuration options >that are only allowed for [secrets] into the [secrets/users/123] section and >vice-versa. > >Example of a config that should fail: >``` >[secrets] >proxy_url = foo > >[secrets/users/123] >timeout = 10 >``` > >Example of a config that should not fail: >``` >[secrets] >debug_level = 9 > >[secrets/users/123] >proxy_url = foo >``` >@lslebodn, does it make sense for you? > I am fine with the 1st patch. But I am not very familiar with the secrets code therefore It would take me much more time to review 2nd patch. I prefer if @jhrozek could review it. LS """ See the full comment at https://github.com/SSSD/sssd/pull/53#issuecomment-259138537
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
