URL: https://github.com/SSSD/sssd/pull/77
Title: #77: Qualify ghost users with RFC2307bis and ldap_nesting_level=0

lslebodn commented:
"""
There are few pep8 issues
```
diff --git a/src/tests/intg/test_ldap.py b/src/tests/intg/test_ldap.py
index 667ae27..bf25d95 100644
--- a/src/tests/intg/test_ldap.py
+++ b/src/tests/intg/test_ldap.py
@@ -952,6 +952,7 @@ def test_remove_user_from_nested_group(ldap_conn,
     ent.assert_group_by_name("group3",
                              dict(mem=ent.contains_only()))
 
+
 def zero_nesting_sssd_conf(ldap_conn, schema):
     """Format an SSSD configuration with group nesting disabled"""
     return \
@@ -961,6 +962,7 @@ def zero_nesting_sssd_conf(ldap_conn, schema):
             ldap_group_nesting_level                = 0
         """).format(INTERACTIVE_TIMEOUT)
 
+
 @pytest.fixture
 def rfc2307bis_no_nesting(request, ldap_conn):
     ent_list = ldap_ent.List(ldap_conn.ds_inst.base_dn)
@@ -974,6 +976,7 @@ def rfc2307bis_no_nesting(request, ldap_conn):
     create_sssd_fixture(request)
     return None
 
+
 def test_zero_nesting_level(ldap_conn, rfc2307bis_no_nesting):
     ent.assert_group_by_name("group1",
                              dict(mem=ent.contains_only("user1")))
```

I will fix them before pushing patches.

Thank you very much for integration test.
BTW downstream tests did not find any regressions.

ACK

LS

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/77#issuecomment-260951073
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to