URL: https://github.com/SSSD/sssd/pull/89
Title: #89: nss: rewrite nss responder so it uses cache_req

lslebodn commented:
"""
Congratulation you broke integration tests on all distributions.
```
ldap_local_override_test.py::test_regr_2790_override FAILED
test_memory_cache.py::test_getgrnam_simple_with_mc FAILED
test_memory_cache.py::test_getgrnam_membership_with_mc FAILED
test_memory_cache.py::test_invalidation_of_gids_after_initgroups FAILED
test_memory_cache.py::test_initgroups_without_change_in_membership FAILED
test_netgroup.py::test_remove_step_by_step FAILED
test_netgroup.py::test_removing_nested_netgroups FAILED
test_netgroup.py::test_offline_netgroups FAILED
```

and uninitialized variable is used.
```
src/responder/nss/nss_protocol_svcent.c: In function ‘nss_protocol_fill_svcent’:
src/responder/nss/nss_protocol_svcent.c:134:15: error: ‘num_aliases’ may be 
used uninitialized in this function [-Werror=maybe-uninitialized]
     aliases = talloc_zero_array(mem_ctx, struct sized_string, num_aliases + 1);
               ^~~~~~~~~~~~~~~~~
src/responder/nss/nss_protocol_svcent.c:121:14: note: ‘num_aliases’ was 
declared here
     uint32_t num_aliases;
              ^~~~~~~~~~~
  CC       src/responder/nss/nss_iface.o
```
Maybe it's related to failures in integration tests.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/89#issuecomment-262825019
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to