URL: https://github.com/SSSD/sssd/pull/107
Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler

jhrozek commented:
"""
Hmm, I'm sorry, I think this is my fault for suggesting we move more stuff out 
of the POSIX signal handler, but I don't think we can remove the watchdog 
overflow. Moving the watchdog overflow out of the signal handler and into the 
tevent loop would effectively disable watchdog, because if sssd is really 
blocked, the tevent fd handler would never be called and the watchdog would 
never kill the process..

So I think the only part that should be moved is the re-initializing of the 
watchdog in case we detect a timeshift..

btw I only realized this when I tried to test that watchdog still works. I set 
a ridiculously short timeout (2) and a breakpoint in sdap_save_user. I only saw 
SIGRT incoming, but the process was never killed.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/107#issuecomment-268495109
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to