URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented: """ On Thu, Feb 23, 2017 at 03:10:12AM -0800, lslebodn wrote: > lslebodn commented on this pull request. > > > > > @@ -3241,6 +3281,7 @@ intgcheck-prepare: > --without-semanage \ > $(INTGCHECK_CONFIGURE_FLAGS); \ > $(MAKE) $(AM_MAKEFLAGS); \ > + $(MAKE) $(AM_MAKEFLAGS) tcurl-test-tool || echo "libcurl tests will be > disabled"; \ > > Ahh, you want to use it in integration tests. Then it should not part of test > `check_PROGRAMS` > IMHO; there are simpler option add it to `noinst_PROGRAMS` or install it only > with integration tests. But we do not have such AM_CONDITION yet OK, done, added to noinst programs. But I was wondering if the OR condition is too much of a hack. Because if libcurl is not installed, we can't build the tcurl-test-tool binary, we have to either make this call conditional (but wrapping it with BUILD_WITH_LIBCURL didn't work for me) or non-fatal (and there I tried prefixing the rule with '-', but that didn't work either). """ See the full comment at https://github.com/SSSD/sssd/pull/152#issuecomment-282322164
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
