URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider

pbrezina commented:
"""
I fixed simo's comments.

The compilation issue on RHEL7 is fixed simple by removing the argument -- give 
it's only a test tool I don't think it is worth spending time implementing this 
myself.

```c
--- a/src/tests/tcurl_test_tool.c
+++ b/src/tests/tcurl_test_tool.c
@@ -317,7 +317,9 @@ int main(int argc, const char *argv[])
         { "put", 'p', POPT_ARG_NONE, NULL, 'p', "Perform a HTTP PUT", NULL },
         { "post", 'o', POPT_ARG_NONE, NULL, 'o', "Perform a HTTP POST", NULL },
         { "del", 'd', POPT_ARG_NONE, NULL, 'd', "Perform a HTTP DELETE", NULL 
},
+#ifdef POPT_ARG_ARGV
         { "header", 'h', POPT_ARG_ARGV, &opts.headers, '\0', "Add HTTP 
header", NULL },
+#endif
         { "raw", 'r', POPT_ARG_NONE, &opts.raw, '\0', "Print raw protocol 
output", NULL },
         { "verbose", 'v', POPT_ARG_NONE, &opts.verbose, '\0', "Print response 
code and body", NULL },
         /* TLS */
```

I renamed `socket` to `socket_path` so I don't shadow global. And we do not 
support secrets nor kcm in rhel6 so it should be configured `--without-secrets 
--without-kcm`.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/198#issuecomment-289719387
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to