URL: https://github.com/SSSD/sssd/pull/193
Title: #193: UTIL: Use max 15 characters for AD host UPN
mzidek-rh commented:
"""
A rather important nitpick :)
```
diff --git a/src/util/sss_krb5.c b/src/util/sss_krb5.c
index 8dfb6af..a3f066e 100644
--- a/src/util/sss_krb5.c
+++ b/src/util/sss_krb5.c
@@ -57,7 +57,7 @@ sss_krb5_get_primary(TALLOC_CTX *mem_ctx,
* NetBIOS names are limited to 16 (15 + $)
*
https://support.microsoft.com/en-us/help/163409/netbios-suffixes-16th-character-of-the-netbios-name
*/
- primary = talloc_asprintf(mem_ctx, ".15%s$", shortname);
+ primary = talloc_asprintf(mem_ctx, "%.15s$", shortname);
talloc_free(shortname);
return primary;
}
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/193#issuecomment-293578425
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
