URL: https://github.com/SSSD/sssd/pull/247
Title: #247: Subdomain inherit

lslebodn commented:
"""
This  patch set modified  the function `check_subdom_config_file` which is 
called from the function `new_subdomain`.  And this function is already tested 
in unitests.

```
sh$ git grep new_subdomain -- src/tests/
src/tests/cmocka/test_fqnames.c:    /* just to make new_subdomain happy */
src/tests/cmocka/test_fqnames.c:    test_ctx->subdom = new_subdomain(dom, dom, 
SUBDOMNAME, NULL, SUBFLATNAME,
src/tests/cmocka/test_nss_srv.c:#include "db/sysdb_private.h"   /* 
new_subdomain() */
src/tests/cmocka/test_nss_srv.c:    subdomain = new_subdomain(nss_test_ctx, 
nss_test_ctx->tctx->dom,
src/tests/cmocka/test_simple_access.c:#include "db/sysdb_private.h"   /* 
new_subdomain() */
src/tests/sysdb-tests.c:    subdomain = new_subdomain(test_ctx, 
test_ctx->domain,
src/tests/sysdb-tests.c:    subdomain = new_subdomain(test_ctx, 
test_ctx->domain,
src/tests/sysdb-tests.c:    subdomain = new_subdomain(test_ctx, 
test_ctx->domain,
src/tests/sysdb-tests.c:    subdomain = new_subdomain(test_ctx, 
test_ctx->domain,
```

Please provide unit test. for this change.

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/247#issuecomment-296985832
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to