URL: https://github.com/SSSD/sssd/pull/250 Title: #250: cache_req: Use ternary operator instead of bool+switch
lslebodn commented: """ > No, it was decided that just other people like the if more, not that it is > more readable. If they they like it more then it is more readable. >Remember that forcing your opinion on a NACK will be taken into consideration >when you'll be NACKing something ... (which is fine by me, but may not be for >you). If I saw switch + bool earlier you would request change as part of review. But I do not have a resources to review all patches these days due to other tasks. And in this case, your NACK does not count because there are 3 other developers which prefer different version. (3 vs 1) Sorry democracy works. The same applies to any other developer(including me) NACK cannot beet 3+ developers :-) Because reasonable NACK with proper explanation would persuade them. """ See the full comment at https://github.com/SSSD/sssd/pull/250#issuecomment-297930326
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
