URL: https://github.com/SSSD/sssd/pull/256
Author: fidencio
 Title: #256: Just a few small fixes
Action: opened

PR body:
"""
This patch set consists in a few small fixes:

- "NSS: Fix typo inigroups -> initgroups" just fixes a typo;
- "LDAP: Remove duplicated debug message" just removes a duplicated debug 
message;
- "CONTRIB: Force single-thread install to workaround concurrency issues" takes 
the same approach already taken for the intgcheck tests and force single thread 
installation to workaround concurrency issues.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/256/head:pr256
git checkout pr256
From 235e56c6b375bc14b77040e2f139ea0c960a21df Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <[email protected]>
Date: Fri, 28 Apr 2017 16:45:49 +0200
Subject: [PATCH 1/3] NSS: Fix typo inigroups -> initgroups
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Fabiano FidĂȘncio <[email protected]>
---
 src/responder/nss/nss_iface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/responder/nss/nss_iface.c b/src/responder/nss/nss_iface.c
index c40d3d1..6277b4e 100644
--- a/src/responder/nss/nss_iface.c
+++ b/src/responder/nss/nss_iface.c
@@ -191,7 +191,7 @@ int nss_memorycache_update_initgroups(struct sbus_request *sbus_req,
     struct resp_ctx *rctx = talloc_get_type(data, struct resp_ctx);
     struct nss_ctx *nctx = talloc_get_type(rctx->pvt_ctx, struct nss_ctx);
 
-    DEBUG(SSSDBG_TRACE_LIBS, "Updating inigroups memory cache of [%s@%s]\n",
+    DEBUG(SSSDBG_TRACE_LIBS, "Updating initgroups memory cache of [%s@%s]\n",
           user, domain);
 
     nss_update_initgr_memcache(nctx, user, domain, num_groups, groups);

From c52267b5da4b2812b48050c7a5f9d4bc82695e8a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <[email protected]>
Date: Mon, 1 May 2017 20:07:02 +0200
Subject: [PATCH 2/3] LDAP: Remove duplicated debug message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Fabiano FidĂȘncio <[email protected]>
---
 src/providers/ldap/sdap_async_initgroups.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/providers/ldap/sdap_async_initgroups.c b/src/providers/ldap/sdap_async_initgroups.c
index c926ddc..a33975c 100644
--- a/src/providers/ldap/sdap_async_initgroups.c
+++ b/src/providers/ldap/sdap_async_initgroups.c
@@ -3429,7 +3429,6 @@ static void sdap_get_initgr_pgid(struct tevent_req *subreq)
         DEBUG(SSSDBG_TRACE_ALL,
               "No need to check for domain local group memberships.\n");
     } else {
-        DEBUG(SSSDBG_OP_FAILURE, "sdap_ad_check_domain_local_groups failed.\n");
         DEBUG(SSSDBG_OP_FAILURE,
               "sdap_ad_check_domain_local_groups failed, "
               "meberships to domain local groups might be missing.\n");

From 0adc1803cfdc45d7f19f7b6b1c546699954592ab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <[email protected]>
Date: Tue, 2 May 2017 09:33:39 +0200
Subject: [PATCH 3/3] CONTRIB: Force single-thread install to workaround
 concurrency issues
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Fabiano FidĂȘncio <[email protected]>
---
 contrib/fedora/bashrc_sssd | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/contrib/fedora/bashrc_sssd b/contrib/fedora/bashrc_sssd
index ec4e91e..3796bf8 100644
--- a/contrib/fedora/bashrc_sssd
+++ b/contrib/fedora/bashrc_sssd
@@ -104,7 +104,8 @@ warn()
 # and making sure that the NSS and PAM modules have the right SELinux context.
 sssinstall()
 {
-    sudo make -j$PROCESSORS install \
+    # Force single-thread install to workaround concurrency issues
+    sudo make -j1 install \
         && sudo rm -f $SSS_LIBDIR/ldb/modules/ldb/memberof.la \
         && sudo restorecon -v /$SSS_LIB/libnss_sss.so.2 \
                               /$SSS_LIB/security/pam_sss.so
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to