URL: https://github.com/SSSD/sssd/pull/259 Author: fidencio Title: #259: RESPONDER: Also populate cr_domains when initializing the responders Action: opened
PR body: """ sss_resp_populate_cr_domains() must be called also when initializing the responder for basically two reasons: - Some methods of the IFP responder don't call sss_parse_inp_send(), causing then the cr_domains to not be populated when cache_req_select_domains() is called; - As the operation is not that costly, is better to have it done on responder's common code in sss_process_init() than just do it in the IFP responder itself. Resolves: https://pagure.io/SSSD/sssd/issue/3387 Signed-off-by: Fabiano Fidêncio <[email protected]> """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/259/head:pr259 git checkout pr259
From 1d20eafb7e8ba85241b422cd30402d826f2d477a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <[email protected]> Date: Tue, 2 May 2017 19:15:12 +0200 Subject: [PATCH] RESPONDER: Also populate cr_domains when initializing the responders MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit sss_resp_populate_cr_domains() must be called also when initializing the responder for basically two reasons: - Some methods of the IFP responder don't call sss_parse_inp_send(), causing then the cr_domains to not be populated when cache_req_select_domains() is called; - As the operation is not that costly, is better to have it done on responder's common code in sss_process_init() than just do it in the IFP responder itself. Resolves: https://pagure.io/SSSD/sssd/issue/3387 Signed-off-by: Fabiano Fidêncio <[email protected]> --- src/responder/common/responder_common.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c index 7496d29..c40f2c1 100644 --- a/src/responder/common/responder_common.c +++ b/src/responder/common/responder_common.c @@ -1260,6 +1260,14 @@ int sss_process_init(TALLOC_CTX *mem_ctx, goto fail; } + ret = sss_resp_populate_cr_domains(rctx); + if (ret != EOK) { + DEBUG(SSSDBG_CRIT_FAILURE, + "sss_resp_populate_cr_domains() failed [%d]: [%s]\n", + ret, sss_strerror(ret)); + goto fail; + } + DEBUG(SSSDBG_TRACE_FUNC, "Responder initialization complete (%s)\n", rctx->socket_activated ? "socket-activated" :
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
